-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(match-expression): match expression should be evaluated on backend #1069
Conversation
Test image available:
|
Signed-off-by: Thuan Vo <thvo@redhat.com>
Test image available:
|
Remaining tasks:
|
This PR/issue depends on:
|
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Ready for review now! There are a lot more changes than expected but I tried my best to minimize the number of API requests to One fix that might raise questions is in the stored credential table. When a target appears or disappears, I opted to just refresh the entire table (1 API request) instead of each match expression checking themselves (a lot API requests and React reducer is not fit for async handling). |
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1067
Depends on https://github.com/cryostatio/cryostat/issues/1601
Description of the change:
Update front-end handler for async checks when evaluating match expression (i.e. done on server via endpoint
/api/beta/matchExpression
)Motivation for the change:
See #1067