Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): /build_test PR command #1097

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat(ci): /build_test PR command #1097

merged 2 commits into from
Aug 30, 2023

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1053

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Aug 30, 2023
@mwangggg mwangggg added duplicate This issue or pull request already exists feat New feature or request safe-to-test and removed needs-triage Needs thorough attention from code reviewers duplicate This issue or pull request already exists labels Aug 30, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-b9669ceb8b2d62c92de24f9c77b16e3ee781efea sh smoketest.sh

@mwangggg
Copy link
Member Author

demo: mwangggg#2

@mwangggg mwangggg requested review from andrewazores and tthvo August 30, 2023 19:01
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-fd6d87dc6e51f4a411b27324d370de12a7258126 sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-08c6eb3a33807a018fcc78d5bb42724b4b1077fe sh smoketest.sh

tthvo
tthvo reviewed Aug 30, 2023
View reviewed changes
.github/workflows/pr-ci.yml Outdated Show resolved Hide resolved
tthvo
tthvo reviewed Aug 30, 2023
View reviewed changes
.github/workflows/pr-ci.yml Outdated Show resolved Hide resolved
tthvo
tthvo reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments.

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-177c8d6f5439068977b997795bd62f65f5df2aa6 sh smoketest.sh

tthvo
tthvo previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM^^

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-766515d287257b5ebcc04bacce3b4bd412df61da sh smoketest.sh

@andrewazores
Copy link
Member

rebase please

@andrewazores andrewazores changed the title feat(ci): /build_image PR command feat(ci): /build_test PR command Aug 30, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-1ff15240bea928da563287cd6e93c0e12591f45e sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1097-041a3c905ecab78432219d545cf0615b18c499e4 sh smoketest.sh

@andrewazores andrewazores merged commit 0ccdb02 into cryostatio:main Aug 30, 2023
@mwangggg mwangggg deleted the gh_pr branch September 18, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores left review comments

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Limit PR-scoped image builds
3 participants
@mwangggg @andrewazores @tthvo