Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jvmid): enhance UI hints when JVM ID cannot be generated #1119

Merged
merged 20 commits into from
Oct 13, 2023
Merged

feat(jvmid): enhance UI hints when JVM ID cannot be generated #1119

merged 20 commits into from
Oct 13, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 27, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to cryostatio/cryostat#1695

Description of the change:

Updates some user strings and UI elements following docs feedback

@mergify mergify bot added the safe-to-test label Sep 27, 2023
@andrewazores andrewazores added the feat New feature or request label Sep 28, 2023
@andrewazores andrewazores force-pushed the jvmid-ui branch 3 times, most recently from 1bea712 to 77017f2 Compare October 4, 2023 13:56
@andrewazores andrewazores marked this pull request as ready for review October 12, 2023 15:30
@andrewazores
Copy link
Member Author

/build_test

@andrewazores andrewazores requested a review from mwangggg October 12, 2023 15:30
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1119-27c2cbc950bb3f0a6e479e64c6d15a120e727e2f sh smoketest.sh

mwangggg
mwangggg approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@andrewazores andrewazores merged commit ba88f71 into cryostatio:main Oct 13, 2023
18 checks passed
@andrewazores andrewazores deleted the jvmid-ui branch October 13, 2023 20:22
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
@andrewazores @mergify
feat(jvmid): enhance UI hints when JVM ID cannot be generated (#1119)
cf5d3a7 
(cherry picked from commit ba88f71)
@mergify mergify bot mentioned this pull request Oct 13, 2023
Merged
andrewazores added a commit that referenced this pull request Oct 13, 2023
@mergify @andrewazores
feat(jvmid): enhance UI hints when JVM ID cannot be generated (#1119) (…
d7569c9 
…#1138)

(cherry picked from commit ba88f71)

Co-authored-by: Andrew Azores <aazores@redhat.com>
@andrewazores andrewazores mentioned this pull request Oct 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg approved these changes

Assignees
No one assigned
Labels
backport feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @mwangggg