-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade to Patternfly 5 #1153
Conversation
6b66fd9
to
1e98866
Compare
@tthvo just a heads up - this repo got forked into https://github.com/cryostatio/cryostat-web-2.x . This one is the active development one which is linked to the cryostat3 backend. The new fork is cut from a recent commit, and is the one that will continue on (for a short while) for any working targeting 2.4.x that may come. This PR is OK to just stay here in this repo, there is no need to backport this to the 2.x fork once it's ready. |
Ahh thanks for the heads up! I will keep that in mind! |
c12d328
to
4a3d5a1
Compare
c5e483f
to
59627fc
Compare
Closing this as it is way overdue and potentially merge conflicts. Hey @andrewazores, let's create an upstream This PR can serve as a reference to port whichever usable later to upstream branch. |
Yup, I'll be creating upstream release branches ( |
Sounds good! Thanks! |
Merge conflicts are probably just text updates from #1260 |
@tthvo if you can resolve these merge conflicts, we can get this merged into the upstream feature branch so that the work can continue there. Once that branch diverges from |
okay, sounds good! I will have a look at the end of this week! |
Merge conflicts are resolved now. Lots of things and tests are still broken but building web assets with webpack is good (i.e. |
Merging this into the upstream feature branch now. |
This reverts commit ce0ac3f.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1110
Description of the change:
WIP
Motivation for the change:
WIP