Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jmcagent): correct notification handling #1248

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1247
Depends on cryostatio/cryostat#401

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link

This PR/issue depends on:

@andrewazores andrewazores force-pushed the jmc-agent-notifications branch from aacf5af to 6963115 Compare April 23, 2024 18:43
@andrewazores andrewazores requested a review from aali309 April 23, 2024 18:43
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores force-pushed the jmc-agent-notifications branch from 6963115 to 06bd61f Compare April 23, 2024 18:48
@andrewazores andrewazores merged commit c2f01e0 into cryostatio:main Apr 23, 2024
18 checks passed
@andrewazores andrewazores deleted the jmc-agent-notifications branch April 23, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] JMC Agent Live Configuration tab does not update on notification
2 participants