Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topology): delete action should be available for custom targets #1252

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 24, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1251

Description of the change:

  • Update the allowList and blockList to be more flexible based on the tree element.
  • Added check for REALM annotation to ensure that only Custom Target is allowed to be deleted.

image

Motivation for the change:

See #1251

@tthvo tthvo requested a review from a team April 24, 2024 23:08
@tthvo tthvo force-pushed the topology-delete-action branch from 5332e75 to 0e822c2 Compare April 24, 2024 23:08
@andrewazores
Copy link
Member

Looks like it worked - the deletion button appears again, and after clicking it I can see a request sent and success response from the server, and a "target lost" notification. However, the Topology view didn't update on the notification, so I had to navigate away and back to see the updated view state.

Seems like a separate bug, but worth noting. In testing cryostatio/cryostat#407 it looks like Agents deregistering also doesn't trigger Topology to update, so it could be a common root cause.

@andrewazores andrewazores force-pushed the topology-delete-action branch from 0e822c2 to 8d80dfb Compare April 24, 2024 23:28
@andrewazores andrewazores merged commit b12028f into cryostatio:main Apr 24, 2024
18 checks passed
@andrewazores
Copy link
Member

Bypassed the rule this time, but @tthvo please set up your GPG signature again with this email account :-)

@tthvo tthvo deleted the topology-delete-action branch April 25, 2024 03:04
@tthvo
Copy link
Member Author

tthvo commented Apr 25, 2024

Ohh oops! That's odd. Somehow, the commit signature keep being not recognized again...I will check next time :D Thanks :)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Custom Target is no longer deletable from topology view
2 participants