fix(Targets): Target list fails to populate if WebSocket connection is not established

[aali309]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Fixes: #1272

Description of the change:

see #1272

Motivation for the change:

#1272 (comment)

How to manually test:

1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
2. ...

[andrewazores]

I think the fix for this problem should include changing this behaviour:

cryostat-web/src/app/Shared/Services/Targets.service.tsx

Line 38 in 1074c00

.pipe(concatMap((sessionState) => (sessionState === SessionState.USER_SESSION ? this.queryForTargets() : EMPTY)))

ie there are places where getSessionState() is called to prevent things from updating until the websocket is connected. The line linked above prevents the target list from loading until there is a websocket connection. Instead of changing the session state calculation, which I think already accurately reflects the actual websocket connection state, I think it might be better to search for places that call getSessionState() and see if it's really necessary to call it and check for a session.

For example here as well:

cryostat-web/src/app/Shared/Services/Api.service.tsx

Line 85 in 1074c00

.getSessionState()