-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recordings): UI improvements for recording filters #1335
Conversation
e21f3ad
to
7773691
Compare
This PR/issue depends on: |
7773691
to
e436e04
Compare
e436e04
to
04f3d9a
Compare
Awesome work on the filter redesign here, these look and feel great to use! One behaviour I think might be worth changing: To me, it "feels" like a Continuous recording should be included in a "duration longer than X" filter, because Continuous ~= "Infinity". I can get the result I want here by putting in the "duration longer than X" filter plus ticking the Continuous checkbox, but somehow this doesn't feel quite intuitive to me. |
Maybe hitting Enter/clicking Search with only a duration lower bound should auto-tick the Continuous checkbox? |
I think this idea make sense. Just that we have a filter value of "Continuous", which that checkbox handles. If this above idea is implemented, when uncheck the box will now also remove the filters without upper bound? Maybe that would not be okay? |
ea48266
to
6dbc7e3
Compare
The latest commit should have this behaviour. The checkbox is stucked when there is a filter without an upper bound... |
Oh hmmm, I don't see that on my side....Is there anything on the console that might give some insights? It does look like something with webpack when it builds the web assets? |
For this, the filtering behaviour is as intended. But maybe leave out the visual part where the Continuous checkbox is auto-tick? |
Whoops, my bad. Ignore me. I forgot to update dependencies again after switching back to testing this branch! It's all good once I make sure I'm actually building with pf5 haha. |
Hmm. Yes, it's working the way my intuition likes it now, but it does feel like a bug that the box can't be unticked. Maybe disabling it and adding a hover tooltip to explain... ? |
Actually, that sounds good! How about now? |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Depends on #1334
Description of the change:
Minor changes
Major changes