Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): number of matched targets should be updated corretly on notification #1350

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 13, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

Added an additional API fetch to obtain the up-to-date number of matched targets for a credential since the notification message always returns 0.

There is a small side effect: there is a gap between the time when the notification message is received and the table is updated. I think this is still better than the potential confusion when the number of matched targets is 0 (when it should not be).

Motivation for the change:

See #1303 (comment)

…ly on notification message

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo requested a review from andrewazores September 13, 2024 23:05
@tthvo tthvo mentioned this pull request Sep 13, 2024
7 tasks
@tthvo tthvo changed the title fix(credentials): number of matched targets should be updated correct… fix(credentials): number of matched targets should be updated corretly on notification Sep 13, 2024
@andrewazores andrewazores merged commit fd5e7c6 into cryostatio:pf5 Sep 16, 2024
21 checks passed
@tthvo tthvo deleted the pf5-cred branch September 16, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants