Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-target): validation icons should have correct color #1390

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 18, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

Updated the css class to use prefix pf-v5- such that the correct color is applied. This was missed during upgrades.

Before After
image image
image image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. fix safe-to-test labels Sep 18, 2024
@tthvo tthvo requested a review from a team September 18, 2024 19:32
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo force-pushed the custom-target-icon branch from d7a8625 to 0969a1a Compare September 18, 2024 19:41
@andrewazores andrewazores merged commit f443bbc into cryostatio:main Sep 18, 2024
18 checks passed
@tthvo tthvo deleted the custom-target-icon branch September 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. fix safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants