Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handling for 'CHANGED' discovery event #220

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

andrewazores
Copy link
Member

Cryostat backend never emits the 'CHANGED' event type anymore, instead emitting a LOST-FOUND sequence in any scenario where a target modification is detected

Related to cryostatio/cryostat#388

@andrewazores andrewazores requested a review from Alexjsenn May 31, 2021 14:08
@andrewazores andrewazores force-pushed the remove-changed-event branch from 756b8f1 to c3ec6c9 Compare May 31, 2021 14:10
Alexjsenn
Alexjsenn previously approved these changes Jun 3, 2021
Cryostat backend never emits the 'CHANGED' event type anymore, instead emitting a LOST-FOUND sequence in any scenario where a target modification is detected
@andrewazores
Copy link
Member Author

Cleanly rebased.

Copy link
Contributor

@Alexjsenn Alexjsenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect!

@andrewazores andrewazores merged commit e90e4ed into cryostatio:main Jun 3, 2021
@andrewazores andrewazores deleted the remove-changed-event branch June 3, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants