fix(auth): Skip login when using noop auth

[jan-law]

Fixes #327

NoopAuthForm automatically calls onSubmit on first load. The user is immediately directed to the dashboard.

[andrewazores]

This can still end up broken :-)

If I modify the Cryostat backend so that the BasicAuthManager reports its authentication method as "Broken", then the string 'Broken' will be passed into this function as method. This happens at runtime, where the as AuthMethod type cast means nothing (since this is only a TypeScript compile-time check). !!validMethod will be true because validMethod is just method which is a non-empty string, and so we call authMethod.next('Broken').

I think instead of a typecast like method as AuthMethod, what you wanted was to try to reverse-map from the string to the enum, like so: https://stackoverflow.com/questions/43804805/check-if-value-exists-in-enum-in-typescript

let validMethod;
if (Object.values(AuthMethod).includes(method)) {
  validMethod = method as AuthMethod;
} else {
  validMethod = AuthMethod.UNKNOWN;
}
this.authMethod.next(validMethod);
this.authMethod.complete();

[jan-law]

I tried moving the typecast before Object.values(AuthMethod).includes to prevent the error below. Let me know what you think.

ERROR in src/app/Shared/Services/Login.service.tsx:204:44
TS2345: Argument of type 'string' is not assignable to parameter of type 'AuthMethod'.
    202 |   private completeAuthMethod(method: string): void {
    203 |     let validMethod;
  > 204 |     if (Object.values(AuthMethod).includes(method)) {
        |                                            ^^^^^^