fix(archiveuploads): display prompt on cancel or navigation #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displays a React dialog prompt when the user clicks the Cancel button during an active upload, and displays the browser's native prompt to confirm when the user tries to refresh or close the tab/window. Also uses an AbortController/AbortSignal to actually instruct the browser to stop the file upload request if the user does confirm they wish to cancel the upload.
andrewazores
changed the title
hareetd
reviewed
Oct 29, 2021
hareetd
reviewed
Oct 29, 2021
jan-law
reviewed
Oct 29, 2021
hareetd
approved these changes
Oct 29, 2021
jan-law
approved these changes
Oct 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
Displays a React dialog prompt when the user clicks the Cancel button during an active upload, and displays the browser's native prompt to confirm when the user tries to refresh or close the tab/window. Also uses an AbortController/AbortSignal to actually instruct the browser to stop the file upload request if the user does confirm they wish to cancel the upload. (cherry picked from commit dd715af) # Conflicts: # src/app/RecordingList/CancelUploadModal.tsx # src/app/Shared/Services/Api.service.tsx
andrewazores
added a commit
that referenced
this pull request
Oct 29, 2021
andrewazores
added a commit
that referenced
this pull request
Oct 29, 2021
…333) (#334) * feat(archiveuploads): display prompt on cancel or navigation (#333) Displays a React dialog prompt when the user clicks the Cancel button during an active upload, and displays the browser's native prompt to confirm when the user tries to refresh or close the tab/window. Also uses an AbortController/AbortSignal to actually instruct the browser to stop the file upload request if the user does confirm they wish to cancel the upload. (cherry picked from commit dd715af) # Conflicts: # src/app/RecordingList/CancelUploadModal.tsx # src/app/Shared/Services/Api.service.tsx * fixup! feat(archiveuploads): display prompt on cancel or navigation (#333) Co-authored-by: Andrew Azores <aazores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
Fixes #332
Displays a React dialog prompt when the user clicks the Cancel button during an active upload, and displays the browser's native prompt to confirm when the user tries to refresh or close the tab/window. Also uses an AbortController/AbortSignal to actually instruct the browser to stop the file upload request if the user does confirm they wish to cancel the upload.
To test, it's probably best to use the browser devtools' simulated request throttling during the upload, so that there is a reasonable human amount of reaction time to cancel the upload before it completes. If testing in podman the upload is likely to complete very quickly for small-ish JFR files otherwise. After cancelling the request, the devtools' Network tab should show that the request was stopped with less than the total JFR filesize transferred, and subsequent
GET /api/v1/recordingsrequests should show that the uploaded file is not present in the archives.