Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Do not show temporary reconnection errors #339

Merged
merged 2 commits into from
Nov 19, 2021
Merged

fix(notifications): Do not show temporary reconnection errors #339

merged 2 commits into from
Nov 19, 2021

Conversation

jan-law
Copy link
Contributor

@jan-law jan-law commented Nov 19, 2021

Fixes #338

@jan-law jan-law added the fix label Nov 19, 2021
@jan-law jan-law requested a review from andrewazores November 19, 2021 16:20
@jan-law
Copy link
Contributor Author

jan-law commented Nov 19, 2021

Since the web-client can successfully reconnect on a reload, I think addressing the err.stack and err.message accesses when err is nullable is a worthy first step patch to fix this problem.

Note that the web-client in the main branch automatically re-connects to the backend after a disconnection by remaining in the CREATING_USER_SESSION_STATE until the WebSocket connection succeeds:
image

@andrewazores andrewazores merged commit f9760bc into cryostatio:main Nov 19, 2021
@jan-law jan-law deleted the fix-websocket-disconnect branch November 19, 2021 18:02
mergify bot pushed a commit that referenced this pull request Nov 19, 2021
fix(notifications): Do not show temporary reconnection errors (#339)
4e3acd2 
* Do not show temporary reconnection errors

* fixup! Do not show temporary reconnection errors

(cherry picked from commit f9760bc)
@mergify mergify bot mentioned this pull request Nov 19, 2021
Merged
jan-law pushed a commit that referenced this pull request Nov 19, 2021
@mergify
fix(notifications): Do not show temporary reconnection errors (#339) (#…
6542ddb 
…340)

* Do not show temporary reconnection errors

* fixup! Do not show temporary reconnection errors

(cherry picked from commit f9760bc)

Co-authored-by: Janelle Law <jalaw@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad error handling when WebSocket connection fails
2 participants
@jan-law @andrewazores