Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): add rule creation form and deletion action #380

Merged
merged 7 commits into from
Feb 25, 2022

Conversation

andrewazores
Copy link
Member

Fixes #377

For CORS/devserver testing you may need to use https://github.com/cryostatio/cryostat/pull/838 on the backend.

@andrewazores andrewazores added the feat New feature or request label Feb 24, 2022
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well. I'm also assuming when you implement the match expression validation, there'll be some helper text to indicate the correct syntax for that field.

src/app/Rules/CreateRule.tsx Outdated Show resolved Hide resolved
src/app/Rules/CreateRule.tsx Outdated Show resolved Hide resolved
src/app/Rules/CreateRule.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@andrewazores
Copy link
Member Author

This is working well. I'm also assuming when you implement the match expression validation, there'll be some helper text to indicate the correct syntax for that field.

Yea, some helper text and some kind of tie-in to #376 I think. I'll have to experiment with that feature to see what's feasible and how I can present it.

@andrewazores andrewazores merged commit 2c290eb into cryostatio:main Feb 25, 2022
@andrewazores andrewazores deleted the rules-creation-ui branch February 25, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Rules creation/deletion
3 participants