-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rules): add rule creation form and deletion action #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well. I'm also assuming when you implement the match expression validation, there'll be some helper text to indicate the correct syntax for that field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well.
Yea, some helper text and some kind of tie-in to #376 I think. I'll have to experiment with that feature to see what's feasible and how I can present it. |
Fixes #377
For CORS/devserver testing you may need to use https://github.com/cryostatio/cryostat/pull/838 on the backend.