Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): add match expression evaluation component to rule creation form #381

Merged
merged 8 commits into from
Feb 25, 2022
Merged

feat(rules): add match expression evaluation component to rule creation form #381

merged 8 commits into from
Feb 25, 2022

Conversation

andrewazores
Copy link
Member

Related to #376

@andrewazores andrewazores added the feat New feature or request label Feb 25, 2022
hareetd
hareetd reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working well and the UI looks great too! I just had one question about the code.

jan-law
jan-law reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the examples look very nice. I just had a couple questions/suggestions to make the form easier to use.

src/app/Rules/MatchExpressionEvaluator.tsx Show resolved Hide resolved
src/app/Rules/MatchExpressionEvaluator.tsx Outdated Show resolved Hide resolved
src/app/Rules/MatchExpressionEvaluator.tsx Show resolved Hide resolved
@andrewazores andrewazores merged commit 0018bc5 into cryostatio:main Feb 25, 2022
@andrewazores andrewazores deleted the rules-ui-matchexpr branch February 25, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hareetd hareetd hareetd left review comments

@jan-law jan-law jan-law approved these changes

Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewazores @hareetd @jan-law