fix(jmx): populate credentials table via notification only #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove redundant state var fix target message filter
andrewazores
approved these changes
Apr 11, 2022
andrewazores
pushed a commit
to andrewazores/cryostat-web
that referenced
this pull request
Apr 12, 2022
…o#404) remove redundant state var fix target message filter
andrewazores
added a commit
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403
When credentials were added or deleted, both
refreshStoredTargetsListand the notification subscriptions attempted to update thestoredTargetslist at the same time. When an item was deleted, the resultingstoredTargetslist became empty.refreshStoredTargetsListshould only be called on page refresh. Only notification subscriptions will update the table from now on. I also removed the state variableisEmptyand simply checked forstoredTargets.length === 0.Planning to add unit tests for this component in a separate PR.