Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(archives): Redesign "All Archives" view #431

Merged
merged 69 commits into from
Jul 29, 2022
Merged

feat(archives): Redesign "All Archives" view #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
c3a4259
Populate TreeView with Targets
Apr 19, 2022
044fb03
Formatting
Apr 20, 2022
eba85ee
Start converting TreeView into a nested Table
May 4, 2022
16160c9
Start building nested table
May 4, 2022
b254ce5
Make target rows expandable
May 5, 2022
78671ff
Add a nested archived recordings table; refresh is not working, however
May 5, 2022
469dd95
Retrieving updated nested archived recordings table works. Try refact…
May 5, 2022
f7538b1
Revert changes to the archived recordings table
May 6, 2022
9504516
Remove handling retrieving recordings from the AllArchivedRecordings …
May 6, 2022
b9460a6
Consolidate nested and regular archived recordings tables into one co…
May 6, 2022
89bf3a4
ArchivedRecordingsTable uses the archivedRecordings GraphQL query to …
May 10, 2022
01af987
Add separate table for uploaded recordings. Refactor component names.
May 10, 2022
22e9230
Refactoring
May 11, 2022
0e7770d
Update target list upon recieving TargetJvmDiscovery notification
May 12, 2022
52bc59c
Ensure nested archived recordings table data is only queried for upon…
Jun 2, 2022
fac547a
Add targets search feature
Jun 2, 2022
10e59c6
fixup! Add targets search feature
Jun 2, 2022
3dbca06
Place 'All Targets' and 'Uploads' tables into separate Tabs
Jun 2, 2022
9cf6a31
Only load the uploaded archived recordings if the tab for it is selected
Jun 3, 2022
8de4ca6
Fix imports
Jun 3, 2022
95866fa
Start combining the UploadedArchivedRecordingsTable with the Archived…
Jun 3, 2022
714232a
Continue refactoring the ArchivedRecordingsTable
Jun 3, 2022
e0bbd12
Ensure the Uploads table properly refreshes its recordings list
Jun 6, 2022
f13aa25
Remove unnecessary imports
Jun 7, 2022
3aa6911
Start updating tests
Jun 7, 2022
1ffd3f9
Add new Archives folder under test
Jun 8, 2022
3c726e8
Use the new aggregate count field to build a Map of targets to their …
Jun 15, 2022
58eaebb
fixup! Use the new aggregate count field to build a Map of targets to…
Jun 15, 2022
b29248f
Update target/count state using notifications
Jun 15, 2022
d1e459a
fixup! Update target/count state using notifications
Jun 15, 2022
92fce00
Update count using callback from child table(s)
Jun 16, 2022
3ff141a
Change target from optional to required in the ArchivedRecordingsTabl…
Jun 16, 2022
306c57c
fixup! Change target from optional to required in the ArchivedRecordi…
Jun 17, 2022
966f6b8
Refactoring
Jun 17, 2022
527c276
Remove count updating from the ArchivedRecordingsTable. Start convert…
Jun 18, 2022
aabc83a
Finish converting Map<Target, count> state to separate arrays
Jun 20, 2022
c5f04fc
fixup! Finish converting Map<Target, count> state to separate arrays
Jun 21, 2022
350698f
Fix error where ActiveRecordingSaved notifications result in duplicat…
Jun 21, 2022
893f3dc
Add LoadingView to the All Targets table
Jun 21, 2022
426ec63
Experiment with separating processing of parent rows from target rows
Jun 29, 2022
d7d4f37
Separate processing of parent and child rows. Do a deep compare befor…
Jun 29, 2022
4c9711b
Cleanup notification handling
Jun 30, 2022
95ac28d
Map expanded rows based on targets instead of row index
Jul 9, 2022
2b253e4
Change all index-based state derivation to target-based. Use this cha…
Jul 13, 2022
9716219
Further cleanup
Jul 13, 2022
46c38e4
Further cleanup
Jul 14, 2022
b1c238a
Refactoring
Jul 15, 2022
4057cba
Update Patternfly package to latest
Jul 15, 2022
c16f335
Make the nested table small and scrollable to fix whitespace scrollin…
Jul 16, 2022
f5e04cf
Hide targets with zero recordings
Jul 16, 2022
e8fc5de
fixup! Hide targets with zero recordings
Jul 16, 2022
989e0ea
Fix rebase
Jul 18, 2022
5da2243
Add missing licenses
Jul 18, 2022
3e272a4
Add EmptyState when recordings list is empty
Jul 18, 2022
27c6fbb
Refactoring
Jul 18, 2022
7a50ad1
Start updating tests
Jul 19, 2022
9e7bc3d
Update snapshots due to the Patternfly packages update
Jul 19, 2022
5156d67
Refactoring
Jul 19, 2022
62d4c54
Add Archives test
Jul 21, 2022
c64c298
Add RecordingsTable test
Jul 21, 2022
62472cd
fixup! Add RecordingsTable test
Jul 21, 2022
c4f2e18
Start updating the ArchivedRecordingsTable test
Jul 26, 2022
987489e
Finish updating the ArchivedRecordingsTable test
Jul 27, 2022
f4f282b
Start adding AllTargetsArchivedRecordingsTable test
Jul 28, 2022
02c839f
fixup! Start adding AllTargetsArchivedRecordingsTable test
Jul 28, 2022
90a2103
fixup! Start adding AllTargetsArchivedRecordingsTable test
Jul 28, 2022
882fb73
Finish adding AllTargetsArchivedRecordingsTable test
Jul 29, 2022
e183e2c
Fix changes from rebase
Jul 29, 2022
b8c5600
Cleanup
Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@
"yarn": "^1.22.13"
},
"dependencies": {
"@patternfly/react-core": "^4.157.3",
"@patternfly/react-icons": "^4.11.17",
"@patternfly/react-styles": "^4.11.16",
"@patternfly/react-table": "^4.30.3",
"@patternfly/react-core": "^4.224.1",
"@patternfly/react-icons": "^4.75.1",
"@patternfly/react-styles": "^4.74.1",
"@patternfly/react-table": "^4.93.1",
"@types/lodash": "^4.14.175",
"express": "^4.17.1",
"react": "^17.0.2",
Expand Down
312 changes: 0 additions & 312 deletions src/app/Archives/AllArchivedRecordingsTable.tsx
View file
Open in desktop

This file was deleted.

Loading