-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(submodule): push update to parent submodule #470
Conversation
66e09c0
to
be84b86
Compare
There's a check to ensure that the branch we're on matches the branch the submodule points to. This prevents an issue where we create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks
* ci(submodule): push update to parent submodule * Use remote branch with check * tmp: use fork * fix variables * point git config to gitmodules * move to own workflow, update rev-parse * don't use fork (cherry picked from commit 940b9d2)
* ci(submodule): push update to parent submodule * Use remote branch with check * tmp: use fork * fix variables * point git config to gitmodules * move to own workflow, update rev-parse * don't use fork (cherry picked from commit 940b9d2) Co-authored-by: Elliott Baron <ebaron@redhat.com>
Example workflow run in my fork: https://github.com/ebaron/cryostat-web/actions/runs/2516537219
Example commit from my fork: ebaron/cryostat@d7b51f7
Fixes: #469