Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(hooks): update useSubscriptions to reduce re-rendering #529

Merged
merged 1 commit into from
Sep 30, 2022
Merged

chore(hooks): update useSubscriptions to reduce re-rendering #529

merged 1 commit into from
Sep 30, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 30, 2022

Fixes #528

Cleaned up useSubscriptions hook to remove local states and reduce re-rendering.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Sep 30, 2022
maxcao13
maxcao13 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does seem to speed up the rendering process, very nice!

@andrewazores andrewazores merged commit 8fd9654 into cryostatio:main Sep 30, 2022
@tthvo tthvo deleted the update-sub-hook branch October 3, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Update useSubscriptions hook to reduce re-rendering
3 participants
@tthvo @andrewazores @maxcao13