Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(warning-modal): correct rule display name in warning modal #538

Merged
merged 2 commits into from
Oct 5, 2022
Merged

fix(warning-modal): correct rule display name in warning modal #538

merged 2 commits into from
Oct 5, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 5, 2022

Fixes #535
Related to #533

Correct display for rule-deletion warning modal. We just need to change the column index as first column is the Switch.

@tthvo tthvo added the fix label Oct 5, 2022
@tthvo tthvo requested a review from andrewazores October 5, 2022 05:10
@andrewazores andrewazores merged commit c4972ce into cryostatio:main Oct 5, 2022
@tthvo tthvo deleted the fix-rule-display branch October 5, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
fix
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Incorrect rule display name on deletion dialog
2 participants
@tthvo @andrewazores