Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recording): add form control for archiveOnStop #542

Merged
merged 2 commits into from
Oct 6, 2022
Merged

feat(recording): add form control for archiveOnStop #542

merged 2 commits into from
Oct 6, 2022

Conversation

andrewazores
Copy link
Member

Fixes #541

@andrewazores andrewazores added the feat New feature or request label Oct 6, 2022
tthvo
tthvo previously approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lkonno
Copy link

lkonno commented Oct 6, 2022

  • If Archive on Stop is unchecked and I select the Continuous checkbox, the Archive on Stop option is disabled unchecked. It seems OK.
  • But when I select the Archive on Stop checkbox, the Continuous checkbox is still enabled. If I select the Continuous checkbox now, the Archive on Stop option is disabled, but it is still checked.
    I think that it can cause a wrong expectation to the user as the recording will not be archived on a manual stop.
    IMO the expected behavior would be to only allow one of the options to be selected at a time. It does not need to disable the checkbox, but when one option is selected, uncheck the other option.

test1

lkonno
lkonno approved these changes Oct 6, 2022
View reviewed changes
Copy link

@lkonno lkonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@andrewazores andrewazores merged commit 04acb15 into cryostatio:main Oct 6, 2022
@andrewazores andrewazores deleted the archive-on-stop branch October 6, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkonno lkonno lkonno approved these changes

@tthvo tthvo tthvo left review comments

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees

@dfitzmau dfitzmau

Labels
feat New feature or request needs-documentation
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add "Archive on Stop" control to manual recording creation UI
4 participants
@andrewazores @lkonno @tthvo @dfitzmau