New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): only show retry button for auth failures #545

Merged

andrewazores merged 1 commit into cryostatio:main from tthvo:fix-retry-button

Oct 11, 2022

Member

tthvo commented Oct 10, 2022 •

edited

Loading

Related to #544

Fixes

Retry button should only show on auth failture.
Add missing tests (i.e. checking auth failture view) for EventTypes component.

Chore

Use useSubscriptions hook where possible in Events/Recordings view.
Use React.useMemo and React.useCallback to reduce re-computation of inner functions in Event views.


          fix(auth): only show retry button for auth failures

569fb6c

tthvo added chore fix labels

tthvo requested review from andrewazores and maxcao13

October 10, 2022 23:38

andrewazores approved these changes

View reviewed changes

andrewazores merged commit c8dbc3d into cryostatio:main

tthvo deleted the fix-retry-button branch

October 11, 2022 17:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels