fix(archive): all-archive should properly display when refreshing #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcao13
reviewed
Oct 12, 2022
andrewazores
approved these changes
Oct 12, 2022
andrewazores
force-pushed
the
fix-all-archives
branch
from
c04daa1 to
41ac9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549
Fixes
All Archive view now correctly refresh view when auto-refresh is enabled. The issue was that there is a call to
Array.includes, which only checks object reference.Chore
Counts of archives for each target should not be an saved in an array (i.e. sorting might be supported). Alternative was
Map<string, number>with key istarget.connectUrl. This way, subscriptions to notification channel are only called once inReact.useEffectfor each type.