Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(match-exp): match-expression-evaluator handles non-empty match-expr with no target selected #578

Merged
merged 3 commits into from
Oct 27, 2022
Merged

fix(match-exp): match-expression-evaluator handles non-empty match-expr with no target selected #578

merged 3 commits into from
Oct 27, 2022

Conversation

maxcao13
Copy link
Member

Fixes #573

@maxcao13 maxcao13 added the fix label Oct 27, 2022
@andrewazores andrewazores merged commit 9ec2f03 into cryostatio:main Oct 27, 2022
mergify bot pushed a commit that referenced this pull request Oct 27, 2022
@maxcao13 @mergify
fix(match-exp): match-expression-evaluator handles non-empty match-ex…
73d2df6 
…pr with no target selected (#578)

* fix issue

* format:apply

* update label

Co-authored-by: Andrew Azores <me@andrewazor.es>
(cherry picked from commit 9ec2f03)
@mergify mergify bot mentioned this pull request Oct 27, 2022
Merged
andrewazores pushed a commit that referenced this pull request Oct 27, 2022
@mergify @maxcao13
fix(match-exp): match-expression-evaluator handles non-empty match-ex…
8d7ce80 
…pr with no target selected (#578) (#581)

* fix issue

* format:apply

* update label

Co-authored-by: Andrew Azores <me@andrewazor.es>
(cherry picked from commit 9ec2f03)

Co-authored-by: Max Cao <macao@redhat.com>
@maxcao13 maxcao13 deleted the no-match-expression branch October 27, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@tthvo tthvo Awaiting requested review from tthvo

Assignees
No one assigned
Labels
backport fix
Projects
No open projects
2.2.0 Release
Status: Done
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] match expression evaluator says "no match expression" when there is one but no target is selected
2 participants
@maxcao13 @andrewazores