-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-recordings): add error-views and refactor target listener #687
Conversation
e49b884
to
7f883ae
Compare
Error handler for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the changes, great job!
Ohh thanks! Looking back again at To tackle this, I added a small fix with You can review again^^ |
0ca00cf
to
643e6db
Compare
Looks good, just rebase to resolve the conflict please. |
643e6db
to
e706f70
Compare
Fixed #673
Fixed #686
The following fixes were applied:
CustomRecordingForm
.SnapShotRecordingForm
(only auth failure and ssl error will show).CustomRecordingForm
to update UI when the target selection is changed.Others:
SnapShotRecordingForm
.