Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mergify): revert mergify to stop automatically adding needs-triage label #697

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Nov 30, 2022

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #696

Description of the change:

This change reverts mergify from adding the needs triage label to pull requests.

Motivation for the change:

Mergify kept adding the label, which failed the CI, but removing the label would cause Mergify to add it back.

How to manually test:

  1. Start a pull request as a non-cryostat-reviewer.
  2. Notice that mergify doesn't add the label anymore.

@maxcao13
Copy link
Member Author

maxcao13 commented Nov 30, 2022

Unfortunately, PRs actually don't get automatically added with the needs-triage label when being made. GitHub hasn't implemented this within the PR template feature yet for some reason. That was why I tried mergify. There is maybe a way to resolve this if I add

  • review-requested : reviewers
    as a condition so that the label won't be added when we request from all reviewers, and also make the action a toggle.

There is also just a github action which can do it easier. https://github.com/actions/labeler Thoughts?

@andrewazores
Copy link
Member

I think using that Action makes sense. That's a good way to have the label applied only once when a PR is first opened.

@maxcao13
Copy link
Member Author

I'll put it in this pr then.

Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
@andrewazores andrewazores merged commit 7769b09 into cryostatio:main Nov 30, 2022
@maxcao13 maxcao13 deleted the mergify-label-issue branch December 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Revert adding needs-triage to pull requests
2 participants