Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add new workflow which checks if needs-triage is not present #702

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Dec 1, 2022

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #696

Description of the change:

Puts label check in separate workflow.

Motivation for the change:

GitHub CI notice changes in labels until seemingly being notified from the labeled event.

How to manually test:

maxcao13#5

Notes:

This will result in the CI tests to still run if the label is present or not.

@maxcao13 maxcao13 added chore Refactor, rename, cleanup, etc. ci fix labels Dec 1, 2022
@maxcao13 maxcao13 requested a review from andrewazores December 1, 2022 18:03
@andrewazores andrewazores merged commit a1fa249 into cryostatio:main Dec 1, 2022
@maxcao13 maxcao13 deleted the fix-ci branch December 1, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Revert adding needs-triage to pull requests
2 participants