fix(archives): convert jvmId to subdirectoryName for web-client requests #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
andrewazores
approved these changes
Apr 25, 2023
andrewazores
force-pushed
the
web-client-from-path-methods
branch
from
57b31d6 to
673e98f
Compare
|
Test image available: |
andrewazores
previously approved these changes
Apr 25, 2023
Signed-off-by: Max Cao <macao@redhat.com>
andrewazores
force-pushed
the
web-client-from-path-methods
branch
from
673e98f to
4bd31e3
Compare
andrewazores
approved these changes
Apr 25, 2023
|
Test image available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: https://github.com/cryostatio/cryostat/pull/1457
Description of the change:
Forgot that the web-client actually uses the archived directory get response data to request for editing labels, viewing reports, and reviewing recordings in Grafana, per target. Particularly the subdirectoryName, since it is now replaced by the jvmId, should be converted like how the backend does it.
Before this change, the requests failed.
How to manually test: