fix(uploads): fix archive upload modal invalid labels popover #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #997
Description of the change:
The change reverts ArchiveUploadModal to append to document body for the popover to show again. I cannot figure out quite the reason why appending the modal to portalRoot makes popperjs think that the popper is being cutoff in some way.
According to an article I read:
But it doesn't seem the reference is ever hidden from view, even when the expandedContent is expanded, and it doesn't make sense why having the modal append to portalRoot vs root/body would add these attributes.
For now, appending the modal to document body is completely ok.
The change also shows the popover if invalid jsons that dont have the
label
field are uploaded.How to manually test:
Archives
->Upload
-> Test out bad metadata json files e.g.{ASDfsadf}
and{"labels":{"asdf"""":"asdf"}}