Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): expose storage API ports externally #235

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jan 10, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat-web#1206

Description of the change:

Opens the smoketest compose ports to requests from the host.

Motivation for the change:

This is required for host requests (ex. browser client on the host) to be able to make requests to the object storage (S3) container, which would be the case when the client tries to download a recording for example.

How to manually test:

  1. Build cryostat3 with feat(recording): API v3 downloads cryostat-web#1206
  2. ./smoketest.bash -O, open localhost:8080 in a browser
  3. Go to Recordings, select localhost:0 target, then try to download an active recording.
  4. Archive an active recording, go to Archives > All Archives, and try to download an archived recording.

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewazores andrewazores merged commit 6357e8e into cryostatio:main Jan 11, 2024
14 of 15 checks passed
@andrewazores andrewazores deleted the smoketest-s3-external branch January 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants