Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(readme): update version of native artifact #114

Merged
merged 3 commits into from
Jun 8, 2022
Merged

chore(readme): update version of native artifact #114

merged 3 commits into from
Jun 8, 2022

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Jun 8, 2022

Related to: #98

@ebaron ebaron added the chore Refactor, rename, cleanup, etc. label Jun 8, 2022
@ebaron ebaron requested review from andrewazores and tthvo June 8, 2022 16:08
andrewazores
andrewazores reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@andrewazores andrewazores left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just make this snippet version-agnostic?

./target/jfr-datasource-*-runner

@tthvo
Copy link
Member

tthvo commented Jun 8, 2022

Maybe just make this snippet version-agnostic?

./target/jfr-datasource-*-runner

Should the code block annotated with bash like here so that the asterisk is highlighted (should work Github readme?) for easier interpretation?

@ebaron ebaron force-pushed the readme-2.2.0-snapshot branch from e16b1ef to 31abbbc Compare June 8, 2022 17:36
@ebaron
Copy link
Member Author

ebaron commented Jun 8, 2022

Added both suggestions

@ebaron ebaron merged commit adf5a4d into cryostatio:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@tthvo tthvo Awaiting requested review from tthvo

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebaron @tthvo @andrewazores