[cantina finding #9] added gasLimit to relayMessage #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voith
force-pushed
the
add-gaslimit
branch
2 times, most recently
from
3f025b9 to
97abe70
Compare
StErMi
reviewed
Feb 24, 2025
| @@ -121,7 +129,12 @@ contract GovernanceCCIPRelay is IGovernanceCCIPRelay { | |||
| receiver: abi.encode(destinationReceiver), | |||
| data: abi.encode(target, payload), | |||
| tokenAmounts: new Client.EVMTokenAmount[](0), | |||
| extraArgs: "", | |||
| extraArgs: Client._argsToBytes( | |||
There was a problem hiding this comment.
@voith does it make sense to track the gasLimit used for the messageId in the MessageRelayed event in order to later to track if the message has revert, which was the value passed for gasLimit?
There was a problem hiding this comment.
I think we can get the gasLimit passed by decoding the data we sent in the transaction. i think it's fine to handle this offchain in the monitoring system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is