Add inversion numbers to remaining rings

cryptimeleon · May 3, 2021 · 5a8c6a1 · 5a8c6a1
1 parent 2156c1a
commit 5a8c6a1
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 6 deletions.
diff --git a/src/main/java/org/cryptimeleon/math/structures/rings/bool/BooleanStructure.java b/src/main/java/org/cryptimeleon/math/structures/rings/bool/BooleanStructure.java
@@ -64,6 +64,16 @@ public RingElement getElement(BigInteger i) {
         return i.mod(BigInteger.valueOf(2)).equals(BigInteger.ZERO) ? BooleanElement.FALSE : BooleanElement.TRUE;
     }
 
+    @Override
+    public double estimateCostInvPerOp() {
+        return 1;
+    }
+
+    @Override
+    public double estimateCostNegPerOp() {
+        return 1;
+    }
+
     @Override
     public boolean isCommutative() {
         return true;

diff --git a/src/main/java/org/cryptimeleon/math/structures/rings/cartesian/ProductRing.java b/src/main/java/org/cryptimeleon/math/structures/rings/cartesian/ProductRing.java
@@ -52,12 +52,14 @@ public RingElement getElement(BigInteger i) {
 
     @Override
     public double estimateCostInvPerOp() {
-        return Arrays.stream(rings).map(Ring::estimateCostInvPerOp).reduce(0.0, Double::sum);
+        // Calculate average inversion cost
+        return Arrays.stream(rings).map(Ring::estimateCostInvPerOp).reduce(0.0, Double::sum) / rings.length;
     }
 
     @Override
     public double estimateCostNegPerOp() {
-        return Arrays.stream(rings).map(Ring::estimateCostNegPerOp).reduce(0.0, Double::sum);
+        // Calculate average negation cost
+        return Arrays.stream(rings).map(Ring::estimateCostNegPerOp).reduce(0.0, Double::sum) / rings.length;
     }
 
     @Override

diff --git a/src/main/java/org/cryptimeleon/math/structures/rings/extfield/ExtensionField.java b/src/main/java/org/cryptimeleon/math/structures/rings/extfield/ExtensionField.java
@@ -205,6 +205,17 @@ public ExtensionFieldElement getElement(long i) {
         return getElement(BigInteger.valueOf(i));
     }
 
+    @Override
+    public double estimateCostInvPerOp() {
+        // Tested with base field Zp(741618179)
+        return 0.3;
+    }
+
+    @Override
+    public double estimateCostNegPerOp() {
+        return constant.getStructure().estimateCostNegPerOp();
+    }
+
     /**
      * Map an integer b to an element in this field.
      * <p>

diff --git a/src/main/java/org/cryptimeleon/math/structures/rings/integers/IntegerRing.java b/src/main/java/org/cryptimeleon/math/structures/rings/integers/IntegerRing.java
@@ -51,6 +51,16 @@ public IntegerElement getElement(BigInteger i) {
         return new IntegerElement(i);
     }
 
+    @Override
+    public double estimateCostInvPerOp() {
+        return 6;
+    }
+
+    @Override
+    public double estimateCostNegPerOp() {
+        return 2;
+    }
+
     @Override
     public IntegerElement restoreElement(Representation repr) {
         return new IntegerElement(repr.bigInt().get());

diff --git a/src/main/java/org/cryptimeleon/math/structures/rings/polynomial/PolynomialRing.java b/src/main/java/org/cryptimeleon/math/structures/rings/polynomial/PolynomialRing.java
@@ -74,6 +74,17 @@ public Polynomial getElement(BigInteger i) {
         return new Polynomial(baseRing.getElement(i));
     }
 
+    @Override
+    public double estimateCostInvPerOp() {
+        // Can only invert polynomials of degree zero
+        return baseRing.estimateCostInvPerOp();
+    }
+
+    @Override
+    public double estimateCostNegPerOp() {
+        return baseRing.estimateCostNegPerOp();
+    }
+
     /**
      * Returns the base ring.
      */

diff --git a/...va/org/cryptimeleon/math/serialization/standalone/params/StructureStandaloneReprTest.java b/...va/org/cryptimeleon/math/serialization/standalone/params/StructureStandaloneReprTest.java
@@ -1,8 +1,6 @@
 package org.cryptimeleon.math.serialization.standalone.params;
 
 import org.cryptimeleon.math.serialization.standalone.StandaloneReprSubTest;
-import org.cryptimeleon.math.structures.groups.RingAdditiveGroupImpl;
-import org.cryptimeleon.math.structures.groups.RingUnitGroupImpl;
 import org.cryptimeleon.math.structures.groups.basic.BasicBilinearGroup;
 import org.cryptimeleon.math.structures.groups.cartesian.ProductGroup;
 import org.cryptimeleon.math.structures.groups.debug.DebugBilinearGroup;
@@ -45,6 +43,25 @@ public void testBilinearGroup(BilinearGroup bilGroup) {
         } catch (UnsupportedOperationException ignored) {}
     }
 
+    public void testBilinearGroupImpl(BilinearGroupImpl bilGroup) {
+        test(bilGroup);
+        test(bilGroup.getG1());
+        test(bilGroup.getG2());
+        test(bilGroup.getGT());
+        try {
+            test(bilGroup.getHashIntoG1());
+        } catch (UnsupportedOperationException ignored) {}
+        try {
+            test(bilGroup.getHashIntoG2());
+        } catch (UnsupportedOperationException ignored) {}
+        try {
+            test(bilGroup.getHashIntoGT());
+        } catch (UnsupportedOperationException ignored) {}
+        try {
+            test(bilGroup.getHomomorphismG2toG1());
+        } catch (UnsupportedOperationException ignored) {}
+    }
+
     public void testBarretoNaehrig() {
         testBilinearGroup(new BarretoNaehrigBasicBilinearGroup(80));
         testBilinearGroup(new BarretoNaehrigBilinearGroup(80));
@@ -64,6 +81,7 @@ public void testLazyAndBasicGroup() {
 
     public void testDebugGroup() {
         testBilinearGroup(new DebugBilinearGroup(128, BilinearGroup.Type.TYPE_1));
+        testBilinearGroupImpl(new DebugBilinearGroupImpl(128, BilinearGroup.Type.TYPE_1));
     }
 
     public void testExtensionField() {
@@ -86,8 +104,6 @@ public void testProductStructures() {
     public void testRingGroups() {
         test(zp.asUnitGroup());
         test(zp.asAdditiveGroup());
-        test(new RingUnitGroupImpl(zp));
-        test(new RingAdditiveGroupImpl(zp));
     }
 
     public void testRings() {