-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bucket support to debug group #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
DebugGroup
andDebugBilinearGroup
DebugBilinearGroup
that takes in group size. Constructor for group bit size has been removed temporarilyformatCounterData
won't be made atomic.How does it work?
DebugGroup
andDebugBilinearGroup
now support using named buckets to distinguish between different sets of counter data. The bucket can be switched via thesetBucket
method (forDebugBilinearGroup
it will switch the buckets for G1, G2, GT, and the pairing counter all together). The system also distinguishes between the buckets sets for G1, G2, and GT, as well as theDebugGroup
not belonging to a bilinear group (if you use the latter directly).Initially, a default bucket is selected which is not named. You can go back to the default bucket via
setDefaultBucket
and it has separate getter methods and result formatting methods. Having it not be named increases the number of methods but ensures you do not need to remember a name such as "default".There are also methods that sum up all the values from all the buckets. These have the suffix "allBuckets".
To format the results, there are still the
formatCounterData()
methods, albeit with some more options.These will currently print the results for all buckets plus the summed up results.