Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve bitget with bug fix and books1 support #460

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

MrrDrr
Copy link
Contributor

@MrrDrr MrrDrr commented Jan 6, 2024

fix: extract account info error and subscribe ORDER_UPDATE error in bitget_futures
dev: add books1 to MARKET_DEPTH for bitget

@MrrDrr
Copy link
Contributor Author

MrrDrr commented Jan 6, 2024

The bitget spot websocket api docs don't mention "books1", but it works when I tested it

@cryptochassis
Copy link
Contributor

We prefer to only support documented features. An exchange can remove any undocumented "features" without notification at any time. Relying on such features can be potentially dangerous in live trading.

@MrrDrr
Copy link
Contributor Author

MrrDrr commented Jan 9, 2024

Agreed. I have removed the books1 support. The current commit contains only bug fixes.

@cryptochassis cryptochassis merged commit 77794fc into crypto-chassis:develop Jan 9, 2024
1 check passed
Copy link

🎉 This PR is included in version 6.6.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants