Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: disorganised wasm binding code in bindings/wasm/src/lib.rs #225

Closed
stevenatcrypto opened this issue Mar 11, 2022 · 1 comment · Fixed by #243
Closed

Problem: disorganised wasm binding code in bindings/wasm/src/lib.rs #225

stevenatcrypto opened this issue Mar 11, 2022 · 1 comment · Fixed by #243
Assignees
@stevenatcrypto

Comments

@stevenatcrypto
Copy link
Collaborator

Suppose if we could separate code to bindings/wasm/src/cosmos_sdk.rs and ethereum.rs (as code in common), and pub use mod functions in lib.rs.
@stevenatcrypto stevenatcrypto self-assigned this Mar 11, 2022
@tomtau
Copy link
Contributor

tomtau commented Mar 11, 2022

yep, also perhaps having a "client" structure to hold urls or something like that

@stevenatcrypto stevenatcrypto mentioned this issue Mar 17, 2022
Merged
tomtau pushed a commit that referenced this issue Mar 18, 2022
@stevenatcrypto
Problem: disorganised wasm binding code in bindings/wasm/src/lib.rs (…
6293def 
…fix #225) (#243)

Solution:
* Separate `bindings/wasm/src/lib.rs` to `cosmos_sdk.rs`, `ethereum.rs` and `nft.rs`.

* Add struct CosmosClient and CosmosClientConfig.

* Test CosmosClient in JS example.
@tomtau tomtau mentioned this issue Mar 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenatcrypto stevenatcrypto

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomtau @stevenatcrypto