Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: duplicate C-Sytle functions for Cosmos SDK in wasm binding #244

Closed
stevenatcrypto opened this issue Mar 17, 2022 · 1 comment · Fixed by #356
Closed

Problem: duplicate C-Sytle functions for Cosmos SDK in wasm binding #244

stevenatcrypto opened this issue Mar 17, 2022 · 1 comment · Fixed by #356
Assignees
@stevenatcrypto

Comments

@stevenatcrypto
Copy link
Collaborator

Since Class-Style functions for Cosmos SDK are added to wasm binding in PR #243. We may delete duplicate C-Style functions and need to update integration-test.
@stevenatcrypto stevenatcrypto self-assigned this Mar 17, 2022
@stevenatcrypto stevenatcrypto mentioned this issue Mar 17, 2022
Merged
@stevenatcrypto
Copy link
Collaborator Author

Working on this issue and then try to integrate integration-test of wasm binding to python script.

This was referenced Apr 26, 2022
Merged
Merged
tomtau pushed a commit that referenced this issue Apr 28, 2022
@stevenatcrypto
Problem: duplicate C-style functions for Cosmos SDK in wasm binding (fix
a0a8f39 
 #244) (#356)

Solution:
Delete C-Style functions (as get_single_bank_send_signed_tx, get_nft_transfer_signed_tx and so on) in wasm binding. Fix to only export class CosmosClient, CosmosMsg and CosmosTx for wasm binding and update integration-test

TODO: For integration-test of wasm binding, suppose to add mod chainmain for organizing the current Cosmos test cases. And mod cronos for organizing new Ethereum test cases.
And we will add another Cosmos-Like chain Terra later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenatcrypto stevenatcrypto

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@stevenatcrypto