Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing ibc message MsgTransfer in Cosmos SDK (fix #167) #186

Merged
merged 10 commits into from
Feb 28, 2022

Conversation

stevenatcrypto
Copy link
Collaborator

@stevenatcrypto stevenatcrypto commented Feb 24, 2022

Close #167

Summary

  1. Add crate ibc-rs for struct of IBC message MsgTransfer in common.

  2. Add C++ and wasm binding.

  3. Add a wasm test case. Only test if the signed MsgTransfer message could be parsed by crypto.org chain of integration-test.

TODO

Suppose to submit new issues and fix them in following PRs.

  1. Support hex address for receiver when invoking binding function get_ibc_transfer_signed_tx (may use crate bech32).

  2. Try to support full test case for MsgTransfer in integration-test. Should validate both sender and receiver balances (in different chains).

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! just one question -- is there any reason not to use the ibc or ibc-proto crates?

@stevenatcrypto
Copy link
Collaborator Author

thanks for this! just one question -- is there any reason not to use the ibc or ibc-proto crates?

I am sorry that I didn't find the crate ibc. It should be better to use MsgTransfer of ibc directly. I will give a try to update. Thanks for the info.

@tomtau
Copy link
Contributor

tomtau commented Feb 24, 2022

no problem!

@stevenatcrypto stevenatcrypto marked this pull request as draft February 24, 2022 08:25
@SHH-HaoZhang
Copy link
Contributor

Tested data is correct

@stevenatcrypto
Copy link
Collaborator Author

Hi @tomtau, I update code to use crate ibc-rs. But there is a dependency issue of crate tendermint for both cosmos-rust and ibc-rs as below:

versions that meet the requirements `=0.23.3` are: 0.23.3

all possible versions conflict with previously selected packages.

  previously selected package `tendermint v0.23.5`

The current version of tendermint is =0.23.3. But ibc-rs upgraded tendermint from =0.23.2 to =0.23.4 directly in this-commit. So I could not find the match version for both crates.

I forked the Github repository cosmos-rust, and sent PR-178 to fix it. But I could only specified dependecy cosmrs and cosmos-sdk-proto from my forked Github repository in this PR. Could you help review if it is all right? Or we need to fork cosmos-rust to Orgnazation crypto-com. What do you think? Thanks.

@stevenatcrypto stevenatcrypto marked this pull request as ready for review February 25, 2022 08:10
@tomtau
Copy link
Contributor

tomtau commented Feb 25, 2022

@stevenatcrypto looks all right -- I forked your repo to https://github.com/crypto-com/cosmos-rust so we can maintain all dependencies under one org until the upstream is updated

@tomtau tomtau merged commit b1dfdb3 into main Feb 28, 2022
@tomtau tomtau deleted the feat/ibc-msg-transfer branch February 28, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: missing ibc message MsgTransfer in Cosmos SDK
3 participants