-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: missing ibc message MsgTransfer
in Cosmos SDK (fix #167)
#186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this! just one question -- is there any reason not to use the ibc
or ibc-proto
crates?
I am sorry that I didn't find the crate |
no problem! |
Tested data is correct |
Hi @tomtau, I update code to use crate
The current version of tendermint is =0.23.3. But I forked the Github repository cosmos-rust, and sent PR-178 to fix it. But I could only specified dependecy |
@stevenatcrypto looks all right -- I forked your repo to https://github.com/crypto-com/cosmos-rust so we can maintain all dependencies under one org until the upstream is updated |
Close #167
Summary
Add crate
ibc-rs
for struct of IBC messageMsgTransfer
in common.Add C++ and wasm binding.
Add a wasm test case. Only test if the signed
MsgTransfer
message could be parsed bycrypto.org
chain of integration-test.TODO
Suppose to submit new issues and fix them in following PRs.
Support
hex
address forreceiver
when invoking binding functionget_ibc_transfer_signed_tx
(may use cratebech32
).Try to support full test case for MsgTransfer in integration-test. Should validate both
sender
andreceiver
balances (in different chains).