Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: u32 for mint and burn amount may be small for ERC20 tokens #49

Closed
devashishdxt opened this issue Aug 20, 2021 · 0 comments · Fixed by #50
Closed

Problem: u32 for mint and burn amount may be small for ERC20 tokens #49

devashishdxt opened this issue Aug 20, 2021 · 0 comments · Fixed by #50
Assignees
@devashishdxt

Comments

@devashishdxt
Copy link
Collaborator

devashishdxt commented Aug 20, 2021 •
edited
Loading

There is already an issue in ibc-go to add support for BigInt transfers. Right now, ibc-go supports u64. On solo machine, only u32 is supported because there is no way to store u64 values in SQLite and PostgreSQL using sqlx. Now that we don't maintain accounts and balances on solo machine, it'll be better to convert database type for amount to TEXT and convert u32 to u64 for mint and burn amounts.
@devashishdxt devashishdxt self-assigned this Aug 20, 2021
devashishdxt added a commit to devashishdxt/ibc-solo-machine that referenced this issue Aug 23, 2021
@devashishdxt
Problem: u32 for mint and burn amount may be small for ERC20 tokens
bd66bc9 
Solution: Changed amount to `u64` and store it in database as `TEXT`. Fixes crypto-com#49.
@devashishdxt devashishdxt mentioned this issue Aug 23, 2021
Merged
devashishdxt added a commit that referenced this issue Aug 23, 2021
@devashishdxt
Problem: u32 for mint and burn amount may be small for ERC20 tokens (…
3d37213 
…#50)

Solution:

- Changed amount to `u64` and store it in database as `TEXT`. Fixes #49.
- Change database type from TEXT to BLOB/BYTEA and use little endian encoding to store u64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devashishdxt devashishdxt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: u32 for mint and burn amount may be small for ERC20 tokens devashishdxt/ibc-solo-machine
1 participant
@devashishdxt