Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic CI in github actions #18

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Add basic CI in github actions #18

merged 1 commit into from
Jul 28, 2021

Conversation

devashishdxt
Copy link
Collaborator

No description provided.

@devashishdxt devashishdxt requested a review from tomtau July 28, 2021 09:29
tomtau
tomtau approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will be executed after it's merged?

@devashishdxt
Copy link
Collaborator Author

I guess this will be executed after it's merged?

Yes. Audit is expected to fail because there's a dependency in tiny-hderive which is unmaintained and prost is not updated to 0.8 in tendermint-proto crate.

@devashishdxt
Copy link
Collaborator Author

I'll create a PR with tiny-hderive and tendermint-proto won't upgrade to 0.8 until this regression is fixed.

@devashishdxt devashishdxt merged commit 3bff72f into crypto-com:main Jul 28, 2021
@devashishdxt devashishdxt deleted the ci branch July 28, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashishdxt @tomtau