Overwrite default relayer config with configs used to setup chains #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
reviewed
Sep 8, 2021
| global: | ||
| timeout: 10s | ||
| light-cache-size: 20 | ||
| paths: |
There was a problem hiding this comment.
paths seem not used anywhere, I guess it's not needed for hermes? Have you tested it already?
There was a problem hiding this comment.
Yes, I have tested, paths is not used and needed for hermes.
Only configurations here are used by Hermes.
|
Could you also add a changelog? |
|
It seems your first commit is not signed? |
macong-cdc
force-pushed
the
add-relayer-config
branch
from
a315962
to
fdbfb2b
Compare
Sorry, just signed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.