Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: can't customize flags of cli commands other than start #70

Merged
merged 6 commits into from
Aug 15, 2022
Merged

Problem: can't customize flags of cli commands other than start #70

merged 6 commits into from
Aug 15, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 15, 2022 •
edited
Loading

Solution:

  • add map config cmd-flags to provide custom flags for all commands

@yihuang
Problem: can't customize flags of cli commands other than start
0cf0813 
Solution:
- add map config `cmd-flags` to provide custom flags for all commands other than `start`
yihuang
yihuang commented Aug 15, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yihuang
yihuang commented Aug 15, 2022
View reviewed changes
pystarport/cluster.py Outdated Show resolved Hide resolved
yihuang
yihuang commented Aug 15, 2022
View reviewed changes
pystarport/cluster.py Outdated Show resolved Hide resolved
yihuang
yihuang commented Aug 15, 2022
View reviewed changes
pystarport/cluster.py Outdated Show resolved Hide resolved
@yihuang yihuang requested a review from mmsqe August 15, 2022 08:51
mmsqe
mmsqe reviewed Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe could make start-flags as default, just add overwrite cmd-flags

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 15, 2022 •
edited
Loading

maybe could make start-flags as default, just add overwrite cmd-flags

start-flags is specific for start cmd as the name suggests, cmd-flags apply to all cmds, and start cmd will have both.
in cronos's case they could be used like this:

    'cmd-flags': '--unsafe-experimental',
    'start-flags': '--trace --inv-check-period 5',

@yihuang yihuang merged commit 97e4038 into crypto-com:main Aug 15, 2022
@yihuang yihuang deleted the init-flag branch August 15, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @mmsqe