Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: chain-abci panic due to failed serialization (CRO-575) #583

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Problem: chain-abci panic due to failed serialization (CRO-575) #583

merged 1 commit into from
Nov 13, 2019

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 13, 2019 •
edited
Loading

Solution:
Skip serialization of invalid json field.

@yihuang
Problem: chain-abci panic due to failed serialization (CRO-575)
135238d 
Solution:
Skip serialization of invalid json field.
@yihuang yihuang requested a review from tomtau November 13, 2019 07:40
@codecov
Copy link

codecov bot commented Nov 13, 2019 •
edited
Loading

Codecov Report

Merging #583 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   67.97%   67.97%   -0.01%     
==========================================
  Files         124      124              
  Lines       14722    14722              
==========================================
- Hits        10008    10007       -1     
- Misses       4714     4715       +1
Impacted Files Coverage Δ
chain-abci/src/app/app_init.rs 66.4% <ø> (ø) ⬆️
chain-core/src/tx/fee/mod.rs 87.68% <0%> (-0.5%) ⬇️

tomtau
tomtau approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 13, 2019
@bors @yihuang
Merge #583
4fa7b87 
583: Problem: chain-abci panic due to failed serialization (CRO-575) r=tomtau a=yihuang

Solution:
Skip serialization of invalid json field.

Co-authored-by: yihuang <huang@crypto.com>
@bors
Copy link
Contributor

bors bot commented Nov 13, 2019

Build succeeded

@bors bors bot merged commit 135238d into crypto-com:master Nov 13, 2019
@yihuang yihuang deleted the cro-575 branch December 19, 2019 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devashishdxt devashishdxt devashishdxt requested changes

@tomtau tomtau tomtau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @tomtau @devashishdxt