Problem: goreleaser is using wrong Env for GitHub token (fixes #251) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-org-chain#251) Solution: updated to use github token + commented out brews, as it may need to be updated manually before permissioning is figured out
tomtau
requested review from
calvinaco,
devashishdxt,
leejw51crypto,
linfeng-crypto and
yihuang
as code owners
calvinaco
approved these changes
Nov 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 27.58% 27.72% +0.14%
==========================================
Files 12 32 +20
Lines 986 5792 +4806
==========================================
+ Hits 272 1606 +1334
- Misses 674 4012 +3338
- Partials 40 174 +134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tomtau
added a commit
that referenced
this pull request
Nov 6, 2020
tomtau
added a commit
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: updated to use github token + commented out brews, as it may need to be updated manually
before permissioning is figured out