Problem: too long default timeout_commit value

[devashishdxt]

Solution: changed default timeout_commit value to 3 seconds. Fixes #486.

These are the new defaults:

# How long we wait for a proposal block before prevoting nil
timeout_propose = "3s"
# How much timeout_propose increases with each round
timeout_propose_delta = "500ms"
# How long we wait after receiving +2/3 prevotes for “anything” (ie. not a single block or nil)
timeout_prevote = "1s"
# How much the timeout_prevote increases with each round
timeout_prevote_delta = "500ms"
# How long we wait after receiving +2/3 precommits for “anything” (ie. not a single block or nil)
timeout_precommit = "1s"
# How much the timeout_precommit increases with each round
timeout_precommit_delta = "500ms"
# How long we wait after committing a block, before starting on the new
# height (this gives us a chance to receive some more precommits, even
# though we already have +2/3).
timeout_commit = "3s"

[devashishdxt]

@lezzokafka @tomtau I've changed the default timeout_commit value to 3 seconds. Let me know if we need to shorten it more.

[codecov]

Codecov Report

Merging #494 (a186778) into master (428c6c7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   10.63%   10.62%   -0.01%     
==========================================
  Files          34       34              
  Lines        4909     4912       +3     
==========================================
  Hits          522      522              
- Misses       4209     4211       +2     
- Partials      178      179       +1     

Flag	Coverage Δ
integration_tests	10.78% <0.00%> (-0.01%)	⬇️
unit_tests	2.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/chain-maind/app/app.go	52.35% <0.00%> (-0.84%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428c6c7...a186778. Read the comment docs.

[tomtau]

this appears to override it globally rather than just change the default "init" value?

[devashishdxt]

this appears to override it globally rather than just change the default "init" value?

Yeah. Ideally it should be changed here: https://github.com/cosmos/cosmos-sdk/blob/3c65c3dacded18f2d0b9f607bc7f679feff6afad/server/util.go#L202

But, that'll change the default value for all cosmos-sdk chains. I didn't find any direct way to change these defaults (other than changing the config.toml after init).

[devashishdxt]

I'll try to patch the config file in postRun of init command.

[devashishdxt]

this appears to override it globally rather than just change the default "init" value?

Changed. Now we only set the default value in PreRun of init command.