Problem: cosmos-sdk 0.46 is not used #828
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
.golangci.yml
Outdated
| issues: | ||
| exclude-rules: | ||
| - text: "Use of weak random number generator" | ||
| linters: | ||
| - gosec |
There was a problem hiding this comment.
may no need to exclude globally, but just on the relevant places?
| // StoreKey is the default store key for NFT | ||
| StoreKey = ModuleName |
There was a problem hiding this comment.
wouldn't there be a conflict on the store?
There was a problem hiding this comment.
as long as we don't enable the SDK module, it might be fine?
There was a problem hiding this comment.
but we will want to migrate to it / enable it?
There was a problem hiding this comment.
There was a problem hiding this comment.
hmm, maybe do that in another PR: #829
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 20.26% 19.05% -1.22%
==========================================
Files 99 94 -5
Lines 11457 11941 +484
==========================================
- Hits 2322 2275 -47
- Misses 8647 9179 +532
+ Partials 488 487 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I was hoping to do these changes in multiple steps (so that code review is easier):
@yihuang @tomtau Can we wait to merge this until next |
|
@devashishdxt fine to break it down in that sequence, but is there a need to wait for (similarly with v5.0.0 -- is the beta ok for now?) |
Final version will use SDK |
that could be achieved with |
conflicts fixed. |
|
/runsim |
|
Simulation tests started and triggered by |
|
❌ |
|
/runsim |
|
Simulation tests started and triggered by |
|
❌ |
|
the timeout change seems don't have effect |
|
maybe the timeout change may need to be merged to the upstream branch first? |
maybe, I'm running locally. |
|
/runsim |
|
Simulation tests started and triggered by |
|
❌ |
|
/runsim |
|
Simulation tests started and triggered by |
|
✅ |
|
all tests passed, ready to be merged anytime @devashishdxt |
|
oh, squash and merge should work |
Solution: - changed app and modules based on the API breaking changes in 0.46 (the new modules are not yet added)
Solution: - changed app and modules based on the API breaking changes in 0.46 (the new modules are not yet added)
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)