This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Problem: Missing secure gRPC channel #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macong-cdc
force-pushed
the
secure-grpc
branch
2 times, most recently
from
434b9b4
to
2879af3
Compare
macong-cdc
force-pushed
the
secure-grpc
branch
from
2879af3
to
e4c4b17
Compare
|
This pull request introduces 1 alert when merging e4c4b17 into 30b1da0 - view on LGTM.com new alerts:
|
Comment on lines
+57
to
+60
| if credentials is None: | ||
| channel = insecure_channel(grpc_endpoint) | ||
| else: | ||
| channel = secure_channel(grpc_endpoint, credentials) |
There was a problem hiding this comment.
I think this may be better:
channel = insecure_channel(grpc_endpoint, credentials) if credentials else insecure_channel(grpc_endpoint)
or
if credentials:
channel = secure_channel(grpc_endpoint, credentials)
else:
channel = insecure_channel(grpc_endpoint)
or using if not credentials:
There was a problem hiding this comment.
I prefer to explicitly check for None to avoid confusion with False.
In this case, it does not matter that much though, as the variable is not a Boolean type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unable to use secure gRPC channel to interact with chain