Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

missing support of sign batch(fix #13) #38

Closed

Conversation

linfeng-crypto
Copy link
Contributor

@linfeng-crypto linfeng-crypto commented Jan 26, 2022

  • use #fmt: off and #fmt: on to ask black to skip formatting certain part of the code, instead of changing max-line-length = 120

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 26, 2022

This pull request introduces 1 alert and fixes 2 when merging a0372a2 into 06b3988 - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information

fixed alerts:

  • 2 for Wrong number of arguments in a class instantiation

@macong-cdc macong-cdc marked this pull request as draft January 26, 2022 07:16
@macong-cdc
Copy link
Collaborator

download and help me to make the multisig example pass.

As mentioned by @linfeng-crypto to me in private message, converting this PR to draft first.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 27, 2022

This pull request introduces 1 alert and fixes 2 when merging efafaf5 into 06b3988 - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information

fixed alerts:

  • 2 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 14, 2022

This pull request introduces 1 alert when merging 4b36eca into 86eff87 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 14, 2022

This pull request introduces 1 alert when merging 22f8ba8 into 86eff87 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@tomtau
Copy link
Contributor

tomtau commented May 31, 2022

can be picked up by @macong-cdc later

@tomtau tomtau closed this May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants