Merge commit from fork #1385
Merge commit from fork #1385
Conversation
* Fix ABS061 * Use typed event * Add changelog * Review feedback * Check for events * Review feedback * Remove unecessary code comments * Set release date * fix changelog --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
|
seems not necessary for cronos since it don't use group. |
yihuang
merged commit a76db61
into
crypto-org-chain:release/v0.50.x
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| break | ||
| } | ||
| } | ||
| intStringLen := int(stringLen) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| break | ||
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| } | ||
| } | ||
| fieldNum := int32(wire >> 3) | ||
| wireType := int(wire & 0x7) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| break | ||
| } | ||
| } | ||
| intStringLen := int(stringLen) |
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
| x.ErrorMessage = value.Interface().(string) | ||
| default: | ||
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: cosmos.group.v1.EventTallyError")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| if fd.IsExtension() { | ||
| panic(fmt.Errorf("proto3 declared messages do not support extensions: cosmos.group.v1.EventTallyError")) | ||
| } | ||
| panic(fmt.Errorf("message cosmos.group.v1.EventTallyError does not contain field %s", fd.FullName())) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Fix ABS061
Use typed event
Add changelog
Review feedback
Check for events
Review feedback
Remove unecessary code comments
Set release date
fix changelog
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...